00:00:00

Close the activation state transition

An audit outage returns an error but leaves the grant active. A retry with a changed activation time is also accepted. Investigate transaction copies, saved retry results and access checks. Failed mutations must disappear and successful requests must not change on replay. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: API Contract Debugging

src/domain/grants.py

BeforeProposed

+1−1

33def activate(state, command):

44 request = lookup(state, 'requests', command)

5 require(request['status'] in ['pending', 'active'], 'request-closed')

5 require(request['status'] == 'pending', 'request-closed')

66 policy = request['policy']

77 require(command['actor'] == policy['owner'], 'owner-required')

88 decisions = list(request['decisions'].values())

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict