00:00:00

Block denied access requests at activation

A request can be activated even after an independent reviewer denies it, and applicants can count their own approval. Follow the decision and activation paths. Enforce independent review and denial precedence while keeping legitimate quorum changes working. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: API Contract Debugging

src/domain/grants.py

BeforeProposed

+1−1

66 policy = request['policy']

77 require(command['actor'] == policy['owner'], 'owner-required')

88 decisions = list(request['decisions'].values())

9 require(bool(decisions), 'review-blocked')

9 require('deny' not in decisions, 'review-blocked')

1010 require(decisions.count('approve') >= policy['quorum'], 'quorum-required')

1111 now = integer(command['now'], 'now')

1212 require(now >= request['openedAt'], 'time-before-request')

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict