00:00:00

Require an independent calibration reviewer

An audit outage leaves batches behind even when the API reports failure. Operators can also approve calibrations they authored. Trace the command transaction and review boundary. Repair rollback and independent approval while keeping successful retries safe. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Data Engineer

src/domain/catalogue.py

BeforeProposed

+1−1

4242

4343def approve(state, command):

4444 item = calibration(state, command['tenant'], command['id'])

45 require(bool(command['actor']), 'independent-review-required')

45 require(item['author'] != command['actor'], 'independent-review-required')

4646 if item['reviewer']:

4747 require(item['reviewer'] == command['actor'], 'already-reviewed')

4848 return {'id': item['id'], 'approved': True}

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict