00:00:00

Correct the order of temperature calibration

A lab captures device readings before a calibration rollout. Processing those readings later produces different values, and Fahrenheit devices disagree with Celsius devices. Trace capture, calibration activation and unit conversion. Restore reproducible results without blocking new calibrations. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Data Engineer

src/domain/measurements.py

BeforeProposed

+2−2

3737

3838

3939def calibrate(row, unit, item):

40 raw = row['raw'] * item['gain'] + item['offset']

41 corrected = celsius(raw, unit)

40 raw = celsius(row['raw'], unit)

41 corrected = raw * item['gain'] + item['offset']

4242 valid = item['lower'] <= corrected <= item['upper']

4343 return {

4444 'id': row['id'],

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict