00:00:00

Keep discarded batches closed

An operator discards a captured batch, but a delayed process command brings it back and allows export. Trace discard, processing and export transitions. Keep discarded batches closed while allowing repeat processing of an already processed batch. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Data Engineer

src/domain/processing.py

BeforeProposed

+1−1

77 item = batch(state, command['tenant'], command['id'])

88 if item['status'] in ['processed', 'exported']:

99 return {'id': item['id'], 'summary': summarize(item['results'])}

10 require(item['status'] in ['captured', 'discarded'], 'batch-discarded')

10 require(item['status'] == 'captured', 'batch-discarded')

1111 results = []

1212 for row in item['rows']:

1313 results.append(calibrate(row, item['unit'], item['calibration']))

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict