00:00:00

Accept readings on a calibration limit

A reading exactly on a calibration limit is reported as out of range. Follow unit conversion, calibrated values and summary counts. Restore inclusive limits while keeping genuinely out-of-range samples rejected. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Data Engineer

src/domain/measurements.py

BeforeProposed

+1−1

3939def calibrate(row, unit, item):

4040 raw = celsius(row['raw'], unit)

4141 corrected = raw * item['gain'] + item['offset']

42 valid = item['lower'] < corrected < item['upper']

42 valid = item['lower'] <= corrected <= item['upper']

4343 return {

4444 'id': row['id'],

4545 'celsius': round(corrected, 4),

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict