00:00:00

Exclude rejected samples from the lab average

The lab export has fewer rows than the captured batch. Its average also changes when an out-of-range sample is added. Follow capture, processing and report assembly. Preserve every sample occurrence and calculate quality statistics from the correct population. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Data Engineer

src/domain/measurements.py

BeforeProposed

+1−1

4848

4949

5050def summarize(rows):

51 accepted = [row['celsius'] for row in rows]

51 accepted = [row['celsius'] for row in rows if row['quality'] == 'accepted']

5252 return {

5353 'count': len(rows),

5454 'accepted': len(accepted),

src/domain/processing.py

BeforeProposed

+1−1

99 return {'id': item['id'], 'summary': summarize(item['results'])}

1010 require(item['status'] == 'captured', 'batch-discarded')

1111 results = []

12 for row in {row['id']: row for row in item['rows']}.values():

12 for row in item['rows']:

1313 results.append(calibrate(row, item['unit'], item['calibration']))

1414 item['results'] = results

1515 item['status'] = 'processed'

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict

00:00:00

Exclude rejected samples from the lab average

Review focus: Data Engineer

src/domain/measurements.py

BeforeProposed

+1−1

4848

4949

5050def summarize(rows):

51 accepted = [row['celsius'] for row in rows]

51 accepted = [row['celsius'] for row in rows if row['quality'] == 'accepted']

5252 return {

5353 'count': len(rows),

5454 'accepted': len(accepted),

src/domain/processing.py

BeforeProposed

+1−1

99 return {'id': item['id'], 'summary': summarize(item['results'])}

1010 require(item['status'] == 'captured', 'batch-discarded')

1111 results = []

12 for row in {row['id']: row for row in item['rows']}.values():

12 for row in item['rows']:

1313 results.append(calibrate(row, item['unit'], item['calibration']))

1414 item['results'] = results

1515 item['status'] = 'processed'

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict