00:00:00

Wrap keyboard traversal and re-enter from the requested direction

A teammate proposes this change for the incident below. Review the patch and its unchanged callers against the complete application contract. Keyboard traversal loses its target at the end of the eligible list and returns to the wrong end when the current control is disabled or absent. Repair next/previous re-entry and circular navigation after eligibility ordering. Empty lists must still return null and no unavailable control may become a target.

Review focus: Architecture Extension

src/services/focus.mjs

BeforeProposed

+1−1

2222 const order = focusOrder(items);

2323 if (!order.length) return {order, focus: null};

2424 const index = order.indexOf(current);

25 const target = index < 0 ? 0 : index + (direction === 'next' ? 1 : -1);

25 const target = index < 0 ? (direction === 'next' ? 0 : order.length - 1) : (index + (direction === 'next' ? 1 : -1) + order.length) % order.length;

2626 return {order, focus: order[target]};

2727}

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict