Observe a period on its final report day

Review the independently proposed patch below, including its unchanged callers. A weekly period whose final day equals through is complete. Preserve null values only for genuinely right-censored periods.

Review focus: Longitudinal cohort analytics

src/services/censoring.py

BeforeProposed

+1−1

66 def apply(frame, through):

7- complete = period_end(F.col('cohort'), F.col('week')) < through

7+ complete = period_end(F.col('cohort'), F.col('week')) <= through

88 return (frame.withColumn('eligible', F.when(complete, F.col('cohortSize')).otherwise(F.lit(0)))

99 .withColumn('retentionBps', F.when(complete, basis_points(F.col('active'), F.col('cohortSize'))))

1010 .withColumn('active', F.when(complete, F.col('active')))

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict

Opening review…

101OneNoughtOne

00:00:00