00:00:00

Assign inclusive page ranges after accepted papers are ordered

Assign inclusive page ranges after accepted papers are ordered. Assess the actual changed files against the documented contract.

Review focus: Repository Engineering

src/services/pagination.rb

BeforeProposed

+6−2

11module Proceedings

22 module Pagination

33 def self.assign(papers)

4 # TODO: return papers with contiguous inclusive page ranges.

5 []

4 page = 1

5 papers.map do |paper|

6 entry = paper.merge('startPage' => page, 'endPage' => page + paper['pages'] - 1)

7 page += paper['pages']

8 entry

9 end

610 end

711 end

812end

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict