00:00:00

Fence channel publication with the current generation

An audit failure leaves a channel visible despite an error response. A stale publisher can also replace a newer channel generation. Follow the command transaction and compare-and-swap check so publication, history and audit state agree. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Data Engineer

src/domain/channels.py

BeforeProposed

+1−1

1010 channel_key = key(command['tenant'], channel)

1111 current = state['channels'].get(channel_key)

1212 generation = current['generation'] if current else 0

13 require(command['expectedGeneration'] <= generation, 'generation-conflict')

13 require(command['expectedGeneration'] == generation, 'generation-conflict')

1414 if current:

1515 require(current['dataset'] == run['dataset'], 'channel-dataset-conflict')

1616 require(run['revision'] >= current['revision'], 'revision-regression')

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict