00:00:00

Match dataset revisions exactly

A retry from an older editor replaces a dataset after another upload has already succeeded. Follow revision validation and quality-run capture. Reject stale uploads while preserving valid replacement and retry behavior. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Data Engineer

src/domain/datasets.py

BeforeProposed

+1−1

1616def replace(state, command):

1717 dataset = lookup(state, 'datasets', command)

1818 require(command['actor'] == dataset['owner'], 'owner-required')

19 require(command['expectedRevision'] <= dataset['revision'], 'revision-conflict')

19 require(command['expectedRevision'] == dataset['revision'], 'revision-conflict')

2020 rows = command['rows']

2121 require(isinstance(rows, list) and len(rows) <= 1000, 'invalid-rows')

2222 for row in rows:

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict