00:00:00

Finish assigned manifests only

An audit failure reserves the vehicle anyway, and a finished route can be finished again. Repair transaction isolation and route state transitions across the application. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/manifests.hpp

BeforeProposed

+1−1

3535}

3636inline Json finish(Json& state,const Json& c) {

3737 auto& manifest=lookup(state,"manifests",c);

38 require(manifest["status"]!="planned","manifest-not-assigned");

38 require(manifest["status"]=="assigned","manifest-not-assigned");

3939 Json vehicleKey={{"tenant",text(c,"tenant")},{"id",manifest["vehicle"]}};

4040 lookup(state,"vehicles",vehicleKey)["available"]=true;

4141 manifest["status"]="finished";

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict