00:00:00

Pick the highest revision after the caller has filtered history

The repository now compares revisions correctly. Examine its caller before approving the change for month-filtered reports.

Review focus: Data Engineering

src/repositories/history.py

BeforeProposed

+1−1

1616 selected = {}

1717 for reading in versions.values():

1818 previous = selected.get(reading.key())

19 if previous is None or reading.revision < previous.revision:

19 if previous is None or reading.revision > previous.revision:

2020 selected[reading.key()] = reading

2121 return list(selected.values())

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict