00:00:00

Service equipment at the exact usage interval

The due list excludes a machine at its exact service interval. Trace the meter comparison and correct the maintenance boundary. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Incident Debugging

src/domain/equipment.py

BeforeProposed

+1−1

2323def due(state, command):

2424 return sorted([item['id'] for (tenant, _), item in state['equipment'].items()

2525 if tenant == command['tenant'] and item['status'] == 'ready'

26 and item['meter'] - item['lastService'] > item['interval']])

26 and item['meter'] - item['lastService'] >= item['interval']])

2727

2828

2929def inspect(state, command):

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict