00:00:00

Finish an open service job only

An audit failure frees equipment and a closed job can finish again. Repair the transaction boundary and terminal state checks across the service repository. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Incident Debugging

src/domain/servicing.py

BeforeProposed

+1−1

1717

1818def finish(state, command):

1919 job = lookup(state, 'jobs', command)

20 require(job['status'] != 'cancelled', 'job-closed')

20 require(job['status'] == 'open', 'job-closed')

2121 require(command['actor'] == job['technician'], 'forbidden')

2222 item = state['equipment'][key(command['tenant'], job['equipment'])]

2323 item['lastService'] = job['meter']

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict