00:00:00

Finish maintenance at its captured meter reading

Meter readings continue arriving while a service job is open. Completion incorrectly marks later usage as serviced. Follow the job snapshot into completion. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Incident Debugging

src/domain/servicing.py

BeforeProposed

+1−1

2020 require(job['status'] == 'open', 'job-closed')

2121 require(command['actor'] == job['technician'], 'forbidden')

2222 item = state['equipment'][key(command['tenant'], job['equipment'])]

23 item['lastService'] = item['meter']

23 item['lastService'] = job['meter']

2424 item['status'] = 'ready'

2525 job['status'] = 'finished'

2626 return deepcopy(job)

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict