00:00:00

Require two approvals at the expense threshold

The approval boundary in the settlement service differs from the documented policy. Reproduce the exact threshold and fix it without changing smaller reports. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/settlement.py

BeforeProposed

+1−1

55def pay(state, command):

66 report = lookup(state, 'reports', command)

77 require(report['status'] == 'pending', 'report-closed')

8 required = 2 if report['amount'] > 1000 else 1

8 required = 2 if report['amount'] >= 1000 else 1

99 require(len(report['approvals']) >= required, 'approval-required')

1010 account = state['budgets'][key(command['tenant'], report['budget'])]

1111 require(account['remaining'] >= report['amount'], 'budget-exhausted')

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict