00:00:00

Count each expense reviewer once

A reviewer double-clicks Approve and a high-value report becomes payable. Follow report approvals into the settlement gate and restore independent reviewer counting. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/expenses.py

BeforeProposed

+1−1

3535 require(report['status'] == 'pending', 'report-closed')

3636 actor = text(command['actor'], 'actor')

3737 require(actor != report['owner'], 'self-approval')

38 if actor:

38 if actor not in report['approvals']:

3939 report['approvals'].append(actor)

4040 return deepcopy(report)

4141

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict