00:00:00

Pay pending expense reports only

An unsuccessful payment changes the available budget. Subsequent retries can also pay a completed report again. Trace transaction isolation and payment state together. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/settlement.py

BeforeProposed

+1−1

55def pay(state, command):

66 report = lookup(state, 'reports', command)

7 require(report['status'] != 'cancelled', 'report-closed')

7 require(report['status'] == 'pending', 'report-closed')

88 required = 2 if report['amount'] >= 1000 else 1

99 require(len(report['approvals']) >= required, 'approval-required')

1010 account = state['budgets'][key(command['tenant'], report['budget'])]

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict