00:00:00

Preserve absent headers in variant identities

Review the independently proposed patch below, including its unchanged callers. A request without Accept-Language and one with an explicitly empty value currently share a variant key. Preserve field presence as well as the normalized name and value.

Review focus: HTTP caching

src/services/variants.go

BeforeProposed

+1−1

2626 rows := [][]any{}

2727 for _, name := range sorted {

2828 value, present := request[name]

29 rows = append(rows, []any{name, present || !present, value})

29 rows = append(rows, []any{name, present, value})

3030 }

3131 encoded, _ := json.Marshal(rows)

3232 return map[string]any{"reusable": true, "key": string(encoded)}, nil

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict