00:00:00

Hash target dependency content in parent cache keys

Review the independently proposed patch below, including its unchanged callers. Changing a leaf source rebuilds the leaf and must invalidate every parent whose consumed artifact content changes. Target names alone cannot identify dependency content.

Review focus: Content-addressed build caching

src/domain/fingerprint.py

BeforeProposed

+1−1

55def signature(definition, inputs):

6 identities = [[item['name'], item['name'] if item['isTarget'] else item['hash']] for item in inputs]

6 identities = [[item['name'], item['hash']] for item in inputs]

77 return document({'inputs': identities, 'recipe': definition['recipe'],

88 'tool': definition['tool'], 'environment': environment(definition)})

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict