00:00:00

Decode JSON Pointer escapes exactly once

Review the independently proposed patch below, including its unchanged callers. Changes target the wrong object member when keys contain a slash or the literal sequence ~1. Implement RFC 6901 token decoding, including the empty member name and the required ~1-before-~0 order.

Review focus: Repository Implementation

src/services/pointers.mjs

BeforeProposed

+1−1

66 requireValue(text.startsWith('/'), 'invalid-pointer');

77 return text.slice(1).split('/').map(part => {

88 requireValue(!/~(?:[^01]|$)/.test(part), 'invalid-pointer');

9 return safeKey(part.replaceAll('~0', '~').replaceAll('~1', '/'));

9 return safeKey(part.replaceAll('~1', '/').replaceAll('~0', '~'));

1010 });

1111}

1212export function index(key, length, insert = false) {

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict