00:00:00

Scope window revisions to the instrument without restoring closed evidence

Scope window revisions to the instrument without restoring closed evidence. Review this proposal against the repository contract and give a concrete example.

Review focus: Repository Engineering

src/repositories/windows.py

BeforeProposed

+1−1

55 chosen = {}

66 seen = {}

77 for row in rows:

8 key = (row['id'],)

8 key = (row['instrument'], row['id'])

99 version = (*key, row['revision'])

1010 if version in seen and seen[version] != row:

1111 raise ContractError('conflicting-window')

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict