00:00:00

Dispatch open parcel routes only

A failed audit write leaves the route dispatched. Separately, a load batch with a missing later parcel keeps earlier parcels loaded. Investigate the shared command transaction and dispatch state machine. Both operations must roll back together with their audit records. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/dispatch.py

BeforeProposed

+1−1

44def dispatch(state, command):

55 route = lookup(state, 'routes', command)

6 require(route['status'] in ['open', 'dispatched'], 'route-closed')

6 require(route['status'] == 'open', 'route-closed')

77 require(bool(route['loaded']), 'empty-route')

88 manifest = []

99 for identifier in route['loaded']:

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict