00:00:00

Permit loading to the exact route capacity

The loader rejects a parcel when its weight exactly matches the remaining vehicle capacity. Follow intake weight validation and route loading. Correct the boundary without allowing an overweight route. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/routing.py

BeforeProposed

+1−1

2020 require(parcel is not None, 'parcels-not-found')

2121 require(parcel['status'] == 'received', 'parcel-not-available')

2222 require(parcel['destination'] == route['destination'], 'wrong-destination')

23 require(route['used'] + parcel['weight'] < route['capacity'], 'capacity-exceeded')

23 require(route['used'] + parcel['weight'] <= route['capacity'], 'capacity-exceeded')

2424 route['used'] += parcel['weight']

2525 route['loaded'].append(identifier)

2626 parcel['status'] = 'loaded'

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict