00:00:00

Wait for every parcel before closing a route

A route can close while parcels are still in transit, and tracking accepts changed payloads under a previously used event ID. Follow route completion and scan receipts. Operators must not lose unfinished deliveries or conflicting event evidence. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/dispatch.py

BeforeProposed

+1−1

2525 require(route['status'] == 'dispatched', 'not-dispatched')

2626 for identifier in route['loaded']:

2727 parcel = state['parcels'][key(command['tenant'], identifier)]

28 require(parcel['status'] in ['in-transit', 'delivered', 'returned'], 'unfinished-route')

28 require(parcel['status'] in ['delivered', 'returned'], 'unfinished-route')

2929 route['status'] = 'closed'

3030 return {'id': route['id'], 'status': 'closed'}

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict