00:00:00

Keep late scans without rolling tracking backward

A late scan overwrites lastSequence even though a newer scan was already applied. Trace event deduplication, ordering and final statuses. Keep late scans as evidence without letting them replace current tracking state. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/tracking.py

BeforeProposed

+1−1

1111 require(prior['sequence'] == sequence and prior['status'] == status, 'event-conflict')

1212 return {'id': parcel['id'], 'status': parcel['status'], 'applied': False}

1313 require(parcel['status'] in ['in-transit', 'delivered', 'returned'], 'parcel-not-dispatched')

14 apply = sequence != parcel['lastSequence']

14 apply = sequence > parcel['lastSequence']

1515 if apply:

1616 require(parcel['status'] == 'in-transit', 'parcel-final')

1717 parcel['status'] = status

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict