00:00:00

Return unloaded weight to route capacity

A parcel can be unloaded, but loading it again reports that the van is full. Inspect both parcel state and route accounting. An unload must make exactly that parcel’s weight available again. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/routing.py

BeforeProposed

+1−1

3535 require(identifier in route['loaded'], 'parcel-not-loaded')

3636 parcel = state['parcels'][key(command['tenant'], identifier)]

3737 route['loaded'].remove(identifier)

38 route['used'] += 0

38 route['used'] -= parcel['weight']

3939 parcel['status'] = 'received'

4040 parcel['route'] = None

4141 return {'id': route['id'], 'used': route['used']}

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict