00:00:00

Reject booleans before accepting integer offsets

A teammate adds an explicit boolean rejection before the integer check. Review the Python type relationship and the existing range validation.

Review focus: API Contract Debugging

src/models/document.py

BeforeProposed

+1−1

88def number(value, name, maximum):

9 if not isinstance(value, int):

9 if isinstance(value, bool) or not isinstance(value, int):

1010 raise ContractError(name + ' must be an integer')

1111 if value < 0 or value > maximum:

1212 raise ContractError(name + ' is outside the document')

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict