src/domain/counting.cjs
BeforeProposed
+3−1
11function count(rows, index) {
2 return rows.length;
2 return index === null
3 ? rows.length
4 : rows.filter((row) => row[index] !== null).length;
35}
46module.exports = { count };
Opening your workspace…
Opening review…
Review the independently proposed patch below, including its unchanged callers. COUNT(column) skips nulls, COUNT(*) counts every row, and SUM over empty or all-null groups is null. The complete application includes native models, services, repository projections, a working preview and visible acceptance cases. Preserve the other documented invariants and run bash test/run.sh.
Review focus: relational-algebra
0 / 10,000 characters · A verdict needs supporting evidence.
Sign in to view your reviews.