00:00:00

Publish an editorial room when its schedule is due

An approved room is scheduled for a specific time. The scheduler skips it at that exact time and publishes it only on a later tick. Follow the scheduling and publication paths, reproduce the boundary case, and make due rooms publish on time without publishing future rooms early. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/releases.cjs

BeforeProposed

+1−1

2828

2929function publishDue(state, command) {

3030 const ready = Object.values(state.rooms)

31 .filter(room => room.tenant === command.tenant && room.status === 'scheduled' && room.scheduledAt < command.now)

31 .filter(room => room.tenant === command.tenant && room.status === 'scheduled' && room.scheduledAt <= command.now)

3232 .sort((a, b) => a.scheduledAt - b.scheduledAt || a.id.localeCompare(b.id));

3333 const published = [];

3434 for (const room of ready) {

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict