00:00:00

Reject saves based on an old document version

Two editors opened the same article version. The second save silently overwrites the first editor’s changes. Inspect version validation and the room refresh path so stale edits are rejected and a fresh room still captures the correct article version. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Repository Implementation

src/domain/documents.cjs

BeforeProposed

+1−1

1111 const key = scoped(command.tenant, command.id);

1212 const previous = state.documents[key];

1313 const version = previous ? previous.version : 0;

14 requireValue(command.expectedVersion <= version, 'version-conflict');

14 requireValue(command.expectedVersion === version, 'version-conflict');

1515 const document = {

1616 id: command.id,

1717 tenant: command.tenant,

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict