00:00:00

Truncate conflicting uncommitted suffixes

Review the independently proposed patch below, including its unchanged callers. AppendEntries replacing the second log entry must remove that conflicting entry and every later uncommitted entry before appending the new suffix. Matching prefixes must retain unrelated existing tails.

Review focus: Consensus log transitions

src/services/truncation.go

BeforeProposed

+1−1

1212 if index < node.Commit {

1313 return 0, errors.New("committed-conflict")

1414 }

15 node.Log = node.Log[:index+1]

15 node.Log = node.Log[:index]

1616 }

1717 if index == len(node.Log) {

1818 node.Log = append(node.Log, entry)

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict