00:00:00

Remove quarantined samples from availability

An audit outage changes stock even though the command fails, and a quarantined sample remains on an operator’s available list. Follow storage isolation and the read projection. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: API Contract Debugging

src/domain/samples.py

BeforeProposed

+1−1

3030 now = integer(command['now'], 'now')

3131 return sorted([sample['id'] for (tenant, _), sample in state['samples'].items()

3232 if tenant == command['tenant'] and sample['holder'] == command['actor']

33 and now < sample['expiresAt']

33 and sample['status'] == 'available' and now < sample['expiresAt']

3434 and sample['quantity'] > 0])

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict