00:00:00

Seatwise: planning guard proposal

Review the independently proposed patch below, including its unchanged callers. Work in the real product frontend and the transactional backend. A party must occupy contiguous columns in one row and its declared size must equal its seat selection. Accessible seats require their configured companion when requested. Charge each selected seat once, apply percentage child discounts with floor rounding, and count confirmed seats individually. The board-to-API adapter and an authoritative planning guard both contain defects. The browser workflow and direct API checks must agree on the same contract. Run bash test/run.sh. The public checks drive Chromium against native HTTP and a real database; each scoring group includes regression safeguards.

Review focus: full-stack-product

src/backend/domain/planning.cjs

BeforeProposed

+4−1

44module.exports = function (state, draft, items) {

55 if (draft.flag)

66 for (const r of items.filter((r) => r.details.accessible))

7 requireValue(true, 'companion-required');

7 requireValue(

8 draft.selected.includes(r.details.companion),

9 'companion-required',

10 );

811 return {

912 usage: Object.fromEntries(items.map((r) => [r.id, 1])),

1013 facts: [{ label: 'Seats in this party', value: items.length }],

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict