00:00:00

Keep unmapped lookup barriers while dropping source roots

Review the independently proposed patch below, including its unchanged callers. The inspector reports an earlier source for generated code that is explicitly unmapped, and relative sources lose their sourceRoot. Repair predecessor lookup without skipping null mappings, and apply the source-root rules without changing absolute sources.

Review focus: Runtime Diagnostics

src/services/lookup.mjs

BeforeProposed

+1−1

11import {sourcePath} from './sources.mjs';

22export function lookup(segments, query, root) {

3 const line = segments.filter(segment => segment.line === query.line && segment.source !== null);

3 const line = segments.filter(segment => segment.line === query.line);

44 let low = 0;

55 let high = line.length;

66 while (low < high) {

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict