Repair historical visibility and positive-net retention

Review the independently proposed patch below, including its unchanged callers. Historical reports must select the latest already-visible observation, and fully refunded orders must not activate a cohort member by themselves. Repair both stages.

Review focus: Longitudinal cohort analytics

src/services/visibility.py

BeforeProposed

+2−2

44def latest(frame, as_of):

5 visible = frame

5 visible = frame.filter(F.col('observed') <= as_of)

66 window = Window.partitionBy('id').orderBy(F.col('observed').desc())

7 return visible.withColumn('_rank', F.row_number().over(window)).filter('_rank = 1').filter(F.col('observed') <= as_of).drop('_rank')

7 return visible.withColumn('_rank', F.row_number().over(window)).filter('_rank = 1').drop('_rank')

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict