Publish the rows captured by the quality run

A reviewed quality run publishes newer, unchecked rows, and the operator can approve their own run. Trace captured rows, independent approval and channel assembly. Publishing must use precisely the approved snapshot. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: Data Engineer

src/domain/channels.py

BeforeProposed

+1−1

1414 if current:

1515 require(current['dataset'] == run['dataset'], 'channel-dataset-conflict')

1616 require(run['revision'] >= current['revision'], 'revision-regression')

17 value = {'channel': channel, 'dataset': run['dataset'], 'revision': run['revision'], 'generation': generation + 1, 'rows': deepcopy(dataset['rows'])}

17 value = {'channel': channel, 'dataset': run['dataset'], 'revision': run['revision'], 'generation': generation + 1, 'rows': deepcopy(run['rows'])}

1818 state['channels'][channel_key] = value

1919 state['history'].append(deepcopy(value) | {'tenant': command['tenant']})

2020 run['status'] = 'published'

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict

00:00:00