Transfer only the current sample revision

A transfer succeeds with a stale revision after material was consumed. Restore optimistic concurrency so the operator must review the current sample first. A teammate proposes the patch below. Review it against the full application contract, including unchanged code. Decide whether it is complete and safe to merge.

Review focus: API Contract Debugging

src/domain/custody.py

BeforeProposed

+1−1

66 sample = lookup(state, 'samples', command)

77 require(sample['holder'] == command['actor'], 'forbidden')

88 require(sample['status'] == 'available', 'sample-unavailable')

9 require(command['expectedRevision'] > 0, 'revision-conflict')

9 require(sample['revision'] == command['expectedRevision'], 'revision-conflict')

1010 require(integer(command['now'], 'now') < sample['expiresAt'], 'sample-expired')

1111 sample['holder'] = text(command['recipient'], 'recipient')

1212 sample['revision'] += 1

Your review

0 / 10,000 characters · A verdict needs supporting evidence.

30 more characters to give a verdict